Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(net): Perform graceful network shutdown before dropping network in NetworkManager #11404

Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat(net): Perform graceful network shutdown before dropping network in NetworkManager #11404

merged 1 commit into from
Oct 2, 2024

Conversation

garwahl
Copy link
Contributor

@garwahl garwahl commented Oct 2, 2024

Closes #11386

Performs a graceful shutdown before dropping the network, when a GracefulShutdown is received

mattsse
mattsse approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit d5bdc1c into paradigmxyz:main Oct 2, 2024
33 of 36 checks passed
@mattsse mattsse added C-enhancement New feature or request A-networking Related to networking in general labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger graceful NetworkManager shutdown in
2 participants
@garwahl @mattsse